Skip to content

Added columns Position X, Position Y, Rotation to fields #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AlexLedis
Copy link

I added support to export position (X, Y) and rotation. This way, you can create a combined BOM with placement information.

We needed this because we need the positioning file with added custom fields, e.g. the article number from ERP. I think this function can be really helpful. I would be delighted if you can merge this addition into the master branch.

Best regards,
Alex

grafik
grafik

@qu1ck
Copy link
Member

qu1ck commented Aug 6, 2024

Hi, thanks for contributing.
I'm not opposed to the idea but as currently implemented it is only useful in narrow set of circumstances. I think to be merged it needs following improvements:

  1. Configurable prescaling factor. Ibom doesn't care about units but if you are displaying numerical values you need to know if it's imperial/metric or bananas. Given that other CADs may use their own internal units, it's best to just have arbitrary prescaling factor.
  2. Origin selection (simply a configurable numerical x.y offset, ideally in case of kicad it can auto detect drill file origin)
  3. Axis direction selection (kicad's Y axis pointing down is controversial even if not uncommon)
  4. Proper comparator for sorting in javascript

All the configurable things will need modifications to the dialog and cli.

@AlexLedis
Copy link
Author

Hi,

thanks for the feedback, I will try to implement the above options, probably in the GUI first.

Best regards,
Alex

@AlexLedis
Copy link
Author

AlexLedis commented Aug 7, 2024

Question: How should I add the controls to the GUI? In "dialog_base.py", where the controls are defined, it says:

"Python code generated with wxFormBuilder (version 3.10.1-0-g8feb16b3)
...
PLEASE DO NOT EDIT THIS FILE!"

Do you have the source files for using wxFormBuilder included in the project?

@qu1ck
Copy link
Member

qu1ck commented Aug 7, 2024

wxFormBuilder source file is settings_dialog.fbp

@AlexLedis
Copy link
Author

Hi,

I have been working on the implementation, but I am unsure how to transmit the settings to Javascript for processing. One way to do it, is to make it ecad-specific, but I would prefer it to be generic. I can include it in pcbdata, but this does not seem correct.

Can you give me a hint?

grafik

@qu1ck
Copy link
Member

qu1ck commented Aug 18, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants