Skip to content

fix: replace eic glob with explicit list #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 18, 2025

Conversation

wdconinc
Copy link
Contributor

Following up on #496, this PR replaces the ghcr.io glob with an explicit list. Also readded the dockerhub glob while we transition because we actually have a different username on dockerhub than on ghcr, so the paths change.

Tag @jasoncpatton

Co-authored-by: Dmitry Kalinkin <[email protected]>
@plexoos
Copy link
Contributor

plexoos commented Apr 18, 2025

Yes, supporting globs would be great. Wondering if this solution is any good: #429

@veprbl
Copy link
Contributor

veprbl commented Apr 18, 2025

@plexoos The issue is not with type of globbing, but with missing support of getting the list from ghcr in the first place.

@wdconinc
Copy link
Contributor Author

Yes, supporting globs would be great. Wondering if this solution is any good: #429

It would be a good addition but not sufficient to make ghcr.io globbing work.

  • The ghcr.io registry uses a different API, so that requires changes.
  • The docker.pkg.github.com registry uses the same API, but uses different authentication (i.e. I haven't gotten it to work yet), but at least all new container images are also published there (verified with docker login docker.pkg.github.com && docker pull docker.pkg.github.com/eic/eic_xl:nightly).

So, nothing that is likely going to work within the scope of this PR.

@rynge rynge merged commit 4a10f4f into opensciencegrid:master Apr 18, 2025
1 check passed
@wdconinc wdconinc deleted the patch-5 branch April 18, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants