Skip to content

fix(egress): allow credential vault bindings with defaultAction allow #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jwx0925 merged 4 commits into from
Jun 16, 2026
Merged

fix(egress): allow credential vault bindings with defaultAction allow #1066

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2895e27
fix(egress): allow credential vault bindings with defaultAction allow
Pangjiping Jun 15, 2026
5b56bd1
refactor(egress): simplify explicitAllowCoversHost to use pol.Evaluat…
Pangjiping Jun 15, 2026
36f5f96
refactor(egress): remove redundant early policy check in validateCand…
Pangjiping Jun 15, 2026
735992f
refactor(egress): remove redundant blank credential name check and up…
Pangjiping Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions components/egress/pkg/credentialvault/vault.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,8 +383,8 @@ func (v *Store) Ready() error {
}

func (v *Store) validateCandidate(credentials map[string]record, bindings map[string]Binding, pol *policy.NetworkPolicy) error {
if len(bindings) > 0 && (pol == nil || len(pol.Egress) == 0) {
return fmt.Errorf("credential bindings require explicit networkPolicy.egress allow rules")
if len(bindings) > 0 && (pol == nil || (len(pol.Egress) == 0 && pol.DefaultAction != policy.ActionAllow)) {
return fmt.Errorf("credential bindings require explicit networkPolicy.egress allow rules or defaultAction allow")
}
for _, b := range bindings {
if err := validateBindingCredentialRefs(b, credentials); err != nil {
Expand Down Expand Up @@ -821,6 +821,12 @@ func explicitAllowCoversHost(pol *policy.NetworkPolicy, host string) bool {
if host == "" {
return false
}
if pol.DefaultAction == policy.ActionAllow {
if strings.HasPrefix(host, "*.") {
return pol.Evaluate("probe."+strings.TrimPrefix(host, "*.")) == policy.ActionAllow
Comment thread
hittyt marked this conversation as resolved.
Outdated
}
return pol.Evaluate(host) == policy.ActionAllow
}
if strings.HasPrefix(host, "*.") {
return explicitAllowRuleMatches(pol, host) && pol.Evaluate("probe."+strings.TrimPrefix(host, "*.")) == policy.ActionAllow
}
Expand Down
12 changes: 10 additions & 2 deletions components/egress/pkg/credentialvault/vault_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,12 +75,20 @@ func TestCredentialVaultCreateSanitizesAndRendersActiveSnapshot(t *testing.T) {
require.Contains(t, payload.Redactions, "secret-token")
}

func TestCredentialVaultRejectsDefaultAllowWithoutExplicitCoverage(t *testing.T) {
func TestCredentialVaultAllowsDefaultAllowWithoutExplicitRules(t *testing.T) {
store := NewStore(nil, func() bool { return true })
pol := testCredentialPolicy(t, `{"defaultAction":"allow","egress":[]}`)

_, err := store.Create(testCredentialVaultRequest(), pol)
require.ErrorContains(t, err, "explicit networkPolicy.egress")
require.NoError(t, err, "defaultAction allow should not require explicit egress rules")
}

func TestCredentialVaultDefaultAllowRespectsExplicitDenyRule(t *testing.T) {
store := NewStore(nil, func() bool { return true })
pol := testCredentialPolicy(t, `{"defaultAction":"allow","egress":[{"action":"deny","target":"code.example.com"}]}`)

_, err := store.Create(testCredentialVaultRequest(), pol)
require.ErrorContains(t, err, "not covered")
}

func TestCredentialVaultRejectsReservedAndDuplicateHeaderNamesCaseInsensitively(t *testing.T) {
Expand Down
Loading