JavaScript: New AddDependency recipe
#6384
Merged
+1,298
−593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new recipe for adding npm dependencies to `package.json`, along with refactoring to share code across dependency recipes. ### Changes - **New `AddDependency` recipe**: Adds dependencies to `package.json` with lock file updates, supporting all dependency scopes (`dependencies`, `devDependencies`, `peerDependencies`, `optionalDependencies`) - **Shared accumulator pattern**: Extracted `DependencyRecipeAccumulator` and helpers (`storeInstallResult`, `runInstallIfNeeded`, `updateNodeResolutionMarker`) to `package-manager.ts` for reuse across dependency recipes - **JSON type guards**: Added `isLiteral()`, `isObject()`, `isArray()`, `isIdentifier()`, `isMember()` to `json/tree.ts` for cleaner type narrowing - **Centralized `DependencyScope` type**: Moved to `node-resolution-result.ts`, excluding `bundledDependencies` (which uses incompatible `string[]` structure) - **Cleanup**: Removed unused exports from `package-manager.ts` (`runAddPackage`, `isLockFile`, `getPackageManagerConfig`, etc.)
knutwannheden
force-pushed
the
greg-js-AddDependency
branch
from
ecb936b to
a0a86b7
Compare
knutwannheden
changed the title
AddDependency JS recipeAddDependency recipe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new recipe for adding npm dependencies to
package.json, along with refactoring to share code across dependency recipes.Changes
AddDependencyrecipe: Adds dependencies topackage.jsonwith lock file updates, supporting all dependency scopes (dependencies,devDependencies,peerDependencies,optionalDependencies)DependencyRecipeAccumulatorand helpers (storeInstallResult,runInstallIfNeeded,updateNodeResolutionMarker) topackage-manager.tsfor reuse across dependency recipesisLiteral(),isObject(),isArray(),isIdentifier(),isMember()tojson/tree.tsfor cleaner type narrowingDependencyScopetype: Moved tonode-resolution-result.ts, excludingbundledDependencies(which uses incompatiblestring[]structure)package-manager.ts(runAddPackage,isLockFile,getPackageManagerConfig, etc.)