Fix RemoveTrailingWhitespace to preserve shebang lines
#6276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtebeek
changed the title
RemoveTrailingWhitespace to preserve shebang lines
timtebeek
commented
Nov 10, 2025
| @Override | ||
| public void defaults(RecipeSpec spec) { | ||
| spec.recipe(new RemoveTrailingWhitespace()) | ||
| .typeValidationOptions(TypeValidation.builder().allowNonWhitespaceInWhitespace(true).build()); |
Member
Author
There was a problem hiding this comment.
This might hint at a parser issue as well, but I've not yet gotten the local server running to troubleshoot this one.
Contributor
There was a problem hiding this comment.
Indeed, the Shebang lines were parsed improperly in JavaScript. #6349 solves this.
Member
Author
There was a problem hiding this comment.
Thanks a lot for diving in!
...e-javascript/src/integTest/java/org/openrewrite/javascript/RemoveTrailingWhitespaceTest.java
Outdated
Show resolved
Hide resolved
Contributor
|
CI taking more than 1hr to run? Is it stuck or what's wrong with this? |
timtebeek
commented
Nov 27, 2025
|
|
||
| import static org.openrewrite.javascript.Assertions.javascript; | ||
|
|
||
| class RemoveTrailingWhitespaceTest implements RewriteTest { |
Member
Author
There was a problem hiding this comment.
I've been told these tests might not execute in CI, and locally I'm getting IllegalStateException: JavaScript RPC process shut down early with exit code 1. Do you think we still need this following #6349 @greg-at-moderne ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
RemoveTrailingWhitespacerecipe removing shebang lines from JavaScript filesCOMPILATION_UNIT_PREFIXto the list of locations to skip when removing trailing whitespaceChanges
COMPILATION_UNIT_PREFIXlocation to preserve shebangs and other file-level prefixesTest plan
New JavaScript integration test passes:
RemoveTrailingWhitespaceTest.doNotRemoveShebang()All existing Java tests pass:
RemoveTrailingWhitespaceTestVerified the fix resolves the issue described in
Remove trailing whitespaceremoves prefix fromgenerate-llms-txt.js#6274Fixes
Remove trailing whitespaceremoves prefix fromgenerate-llms-txt.js#6274🤖 Generated with Claude Code