Skip to content

Type attribution issue on Gradle tasks after 9.2.0 #6225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
timtebeek wants to merge 1 commit into from
Closed

Type attribution issue on Gradle tasks after 9.2.0 #6225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
plugins {
id("org.openrewrite.build.root") version("latest.release")
id("org.openrewrite.build.java-base") version("latest.release")
id("org.openrewrite.build.root") version("2.5.6")
id("org.openrewrite.build.java-base") version("2.5.6")
Comment on lines +2 to +3
Copy link
Member Author

@timtebeek timtebeek Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the first build passes we'll want to revert this change, and update the branch to include master, to show that we then get Object instead of TaskContainer.

Suggested change
id("org.openrewrite.build.root") version("2.5.6")
id("org.openrewrite.build.java-base") version("2.5.6")
id("org.openrewrite.build.root") version("latest.release")
id("org.openrewrite.build.java-base") version("latest.release")

id("org.owasp.dependencycheck") version("latest.release")
}

Expand Down
24 changes: 24 additions & 0 deletions rewrite-gradle/src/test/java/org/openrewrite/gradle/GradleParserTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@
import org.openrewrite.Parser;
import org.openrewrite.SourceFile;
import org.openrewrite.java.tree.J;
import org.openrewrite.java.tree.JavaType;
import org.openrewrite.java.tree.TypeUtils;
import org.openrewrite.test.RewriteTest;
import org.openrewrite.tree.ParseError;

Expand All @@ -29,6 +31,7 @@
import java.util.stream.Stream;

import static org.assertj.core.api.Assertions.assertThat;
import static org.junit.jupiter.api.Assertions.assertTrue;
import static org.openrewrite.gradle.Assertions.*;

class GradleParserTest implements RewriteTest {
Expand Down Expand Up @@ -383,4 +386,25 @@ implementation platform("commons-lang:commons-lang3:3.0",)
)
);
}

@Issue("https://github.com/openrewrite/rewrite-testing-frameworks/pull/836")
@Test
void typeAttributionOnTasks() {
rewriteRun(
//language=groovy
buildGradle(
"""
plugins {
id 'java'
}
tasks.withType(Test) {
}
""",
spec -> spec.beforeRecipe(cu -> {
JavaType tasksType = ((J.MethodInvocation) cu.getStatements().getLast()).getSelect().getType();
assertTrue(TypeUtils.isAssignableTo("org.gradle.api.tasks.TaskContainer", tasksType), tasksType.toString());
})
)
);
}
}