Don't include diff in exception in Result
#4997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to allow clients of OpenRewrite to decide whether to include (or not) the diff text when a source file changed but no changes were reported, extract the logic to a new `Exception`, `UnknownSourceFileChangeException`, passing in the `SourceFile` and diff.
pstreef
approved these changes
Feb 7, 2025
timtebeek
approved these changes
Feb 7, 2025
|
Failures seem unrelated; merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed? / What's your motivation?
In order to allow clients of OpenRewrite to decide whether to include (or not) the diff text when a source file changed but no changes were reported, extract the logic to a new
Exception,UnknownSourceFileChangeException, passing in theSourceFileand diff.Anything in particular you'd like reviewers to focus on?
N/A
Anyone you would like to review specifically?
N/A
Have you considered any alternatives or workarounds?
The workaround would be to read the text of the error message, which is error- and change-prone.
Any additional context
N/A
Checklist
- [ ] I've added unit tests to cover both positive and negative cases