Extend InlineVariable to support local variable assignments

[timtebeek]

What's your motivation?

• Extract part of Convert assigning Switch statements to Switch expressions rewrite-migrate-java#795

[timtebeek]

This is the part that needs review.

[github-actions]

Some suggestions could not be made:

• src/main/java/org/openrewrite/staticanalysis/MinimumSwitchCases.java
  • lines 260-260

[timtebeek]

Turns out we already have a recipe that does something similar, but with not exactly overlapping coverage:

rewrite-static-analysis/src/main/java/org/openrewrite/staticanalysis/InlineVariable.java

Lines 36 to 46 in a779afa

	public class InlineVariable extends Recipe {
	@Override
	public String getDisplayName() {
	return "Inline variable";
	}
	@Override
	public String getDescription() {
	return "Inline variables when they are immediately used to return or throw.";
	}

[Stephan202]

For inspiration around possible edge cases, see the DirectReturn Error Prone check and its tests.

[timtebeek]

For inspiration around possible edge cases, see the DirectReturn Error Prone check and its tests.

Thanks! Added a few similar ones just now in 406c195 ; with that I think we're good to merge this PR. 🙏🏻

[greg-at-moderne]

Maybe we should trigger RemoveUnusedLocalVariables as an after visitor?