[draft] Remove Spring annotations if they repeating in subclasses #698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/main/java/org/openrewrite/java/spring/NotRepeatSpringAnnotationsInSubclasses.java
Outdated
Show resolved
Hide resolved
...ingBoot_1_5/java/org/openrewrite/java/spring/NotRepeatSpringAnnotationsInSubclassesTest.java
Outdated
Show resolved
Hide resolved
…tRepeatSpringAnnotationsInSubclassesTest.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
arodionov
force-pushed
the
remove-repeating-annotations
branch
from
985dea6 to
2ea2faa
Compare
src/main/java/org/openrewrite/java/spring/NotRepeatSpringAnnotationsInSubclasses.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/spring/NotRepeatSpringAnnotationsInSubclasses.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/spring/NotRepeatSpringAnnotationsInSubclasses.java
Outdated
Show resolved
Hide resolved
...ingBoot_1_5/java/org/openrewrite/java/spring/NotRepeatSpringAnnotationsInSubclassesTest.java
Show resolved
Hide resolved
...ingBoot_1_5/java/org/openrewrite/java/spring/NotRepeatSpringAnnotationsInSubclassesTest.java
Show resolved
Hide resolved
|
As discussed we'll park this for now; no need to implement a partial solution when we're blocked on a full solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
What's your motivation?
Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
Any additional context
Checklist