This repository was archived by the owner on Mar 13, 2025. It is now read-only.
generated from moderneinc/rewrite-recipe-starter
-
Notifications
You must be signed in to change notification settings - Fork 16
Migrate to Kotlin 2.1 #627
Draft
barbulescu
wants to merge
8
commits into
openrewrite:main
Choose a base branch
from
barbulescu:kotlin_2_1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- src/test/java/org/openrewrite/kotlin/ChangeTypeTest.java
- lines 18-18
Comment on lines
+100
to
+103
private fun Any?.isInvalid() = this == null | ||
|| this is FirErrorTypeRef | ||
|| this is FirExpression && this.resolvedType is ConeErrorType | ||
|| this is FirResolvedQualifier && classId == null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
private fun Any?.isInvalid() = this == null | |
|| this is FirErrorTypeRef | |
|| this is FirExpression && this.resolvedType is ConeErrorType | |
|| this is FirResolvedQualifier && classId == null | |
private fun Any?.isInvalid() = this == null || | |
this is FirErrorTypeRef || | |
this is FirExpression && this.resolvedType is ConeErrorType || | |
this is FirResolvedQualifier && classId == null |
Adding a quick note here that we've since moved this repository into openrewrite/rewrite; let us know if you'd like help porting over the work you have done here! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
What's your motivation?
Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
Any additional context
Checklist