Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Publishing from a workflow invoked via 'pull_request_target' is not supported.. This must be a policy change, presumably related to recent exploits using pull_request_target (e.g. https://medium.com/@sadi.zane/exploiting-fork-and-pull-request-target-to-compromise-aws-3d3e77873b27). I can't tell where in the stack the policy change actually happened (PyPI in https://docs.pypi.org/trusted-publishers/security-model/ makes the standard warning about pull_request_target being dangerous but doesn't say it's blocked). For what it's worth, I believe our use of pull_request_target is safe since the workflow only runs on code we've reviewed - but if it's blocked, it's blocked. The fix (hopefully) is to trigger the workflow on a push to main branch, and trust that the branch protection rules enforce that this can only happen on PR merge.