Skip to content

Conversation

@schafferde
Copy link

@schafferde schafferde commented Oct 19, 2025

Describe your changes

I split Scanorama into embedding (integrate) and count-correction (correct) modes, instead of running both together. This makes clear what the reported score(s) are describing, as raised in #80 . Also, this corrects the misleadingly low score that the combined method receives (0.1761). The scores for each component are in line with their scores from v1, where the modes were separated. Locally, I computed the two scores to be (without scaling) 0.5220 for integrate and 0.3051 for correct, but there may be minor differences in my computation.

Checklist before requesting a review

  • I have performed a self-review of my code

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI Tests succeed and look good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant