Split Scanorama into two methods, correcting misleading score #88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
I split Scanorama into embedding (integrate) and count-correction (correct) modes, instead of running both together. This makes clear what the reported score(s) are describing, as raised in #80 . Also, this corrects the misleadingly low score that the combined method receives (0.1761). The scores for each component are in line with their scores from v1, where the modes were separated. Locally, I computed the two scores to be (without scaling) 0.5220 for integrate and 0.3051 for correct, but there may be minor differences in my computation.
Checklist before requesting a review
I have performed a self-review of my code
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI Tests succeed and look good!