[feat] add custom RBAC rules #158
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 25, 2025 18:51
…mplate - Introduced an `rbac.extraRules` section in values.yaml to allow users to define additional RBAC rules for the collector. - Updated clusterrole.yaml to incorporate the new RBAC rules dynamically based on the configuration.
- Cleared the `rbac` section in values.yaml to provide a clean slate for users. - Commented out the previous `extraRules` example to avoid confusion while maintaining reference for future customization.
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for custom RBAC rules in the OpenObserve collector Helm chart to enable access to resources outside the default ClusterRole permissions, such as custom resources from third-party API groups.
- Added
rbac.extraRulesconfiguration section invalues.yamlwith example documentation - Updated
clusterrole.yamltemplate to dynamically include additional RBAC rules - Minor formatting change to
scrape_configsarray in prometheus receiver configuration
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| charts/openobserve-collector/values.yaml | Introduces rbac.extraRules configuration with documented examples and minor prometheus config formatting |
| charts/openobserve-collector/templates/clusterrole.yaml | Adds template logic to include custom RBAC rules from values configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add custom RBAC rules support in
values.yamlandclusterroletemplateIn case we want to add a scrape config that would access objects (like custom resources) outside the scope of the default
clusterrolepermissions, we need to have an option to define the rules that should be added to the role.rbac.extraRulessection invalues.yamlto allow users to define additional RBAC rules for the collector.clusterrole.yamlto incorporate the new RBAC rules dynamically based on the configuration.