test: add test ensuring GHSA-f82v-jwr5-mffw doesn't affect Next.js on Netlify
#2778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Package size report No changes
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
serhalp
changed the title
GHSA-f82v-jwr5-mffw doesn't affect Next.js on Netlify
pieh
commented
Mar 22, 2025
Comment on lines
+220
to
+234
| test("requests with x-middleware-subrequest don't skip middleware (GHSA-f82v-jwr5-mffw)", async ({ | ||
| middlewareSubrequestVuln, | ||
| }) => { | ||
| const response = await fetch(`${middlewareSubrequestVuln.url}`, { | ||
| headers: { | ||
| 'x-middleware-subrequest': 'middleware:middleware:middleware:middleware:middleware', | ||
| }, | ||
| }) | ||
|
|
||
| // middleware was not skipped | ||
| expect(response.headers.get('x-test-used-middleware')).toBe('true') | ||
|
|
||
| // ensure we are testing version before the fix for self hosted | ||
| expect(response.headers.get('x-test-used-next-version')).toBe('15.2.2') | ||
| }) |
There was a problem hiding this comment.
This test is inspired by vercel/next.js@52a078d#diff-c5e08cd8ee165bce3a9fb81c8315d6e149b76f6f9b2e53f70bb2f39fb248d2aeR148-R157
Just assertions are hopefully more readable in their intention - goal is to ensure that middleware is not skipped when x-middleware-subrequest request header with 5+ hops is provided ( as then https://github.com/vercel/next.js/blob/cdb9a8c3b355593ab19ee6dec7c59e622bf59c81/packages/next/src/server/web/sandbox/sandbox.ts#L96-L114 this code path with early bail (circuit breaker to prevent infinite recursion) would be executed that would skip execution of actual middleware - at least when self hosting, but we don't even use this code path for our handling)
mrstork
approved these changes
Mar 22, 2025
serhalp
approved these changes
Mar 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation
This is ensuring Next.js apps hosted on Netlify are not affected by GHSA-f82v-jwr5-mffw
Our custom edge middleware implementation doesn't make use of
x-middleware-subrequestheader. But just for good measure - let's add test ensuring that suppling this header to request against app using vulnerable Next.js version (15.2.2, so one patch before fix for self hosted)