Fix + update examples #173
Conversation
|
commit: |
vicb
requested review from
petebacondarwin,
conico974,
james-elicx and
dario-piotrowicz
and removed request for
petebacondarwin
Use ReadableStream.from instead of Readable.toWeb The latter triggers a "This ReadableStream is disturbed" error See cloudflare/workerd#3245
There is a "[unenv] fs.readdirSync is not implemented yet!" error to investigate
Does not build
| init.body = __cf_stream.Readable.toWeb(init.body); | ||
| } | ||
| // https://github.com/cloudflare/workerd/issues/3245 | ||
| body: init.body instanceof __cf_stream.Readable ? ReadableStream.from(init.body) : init.body, |
There was a problem hiding this comment.
Would this fail if init.body is a Readable from unenv ?
There was a problem hiding this comment.
From the top of my head I would say no.
It works with Node (/undici) only because a Readable is async iterable.
And we moved away from unenv Readable because it does not implement async iterator.
There was a problem hiding this comment.
I was thinking about user code actually, since this is overriding the global Request, user code or one of their lib could be using unenv or similar and instanceof would be false
There was a problem hiding this comment.
Ah, got it now.
There should be no more instances of unenv Readable after unjs/unenv#363 (cloudflare/workerd#3245 has some details). Before that it was still possible to create an unenv Readable via the http module.
See cloudflare/workerd#3245 for details/rationale about the fix.
Updated the examples.
The blog and commerce examples fails, I'll create separate issues for them.
-> See #174 and #175, both added to the board.