Added the line of code returning the all drug types in reportingCompatiblity module - #42
Open
sherrif10 wants to merge 1 commit into
Open
Added the line of code returning the all drug types in reportingCompatiblity module#42sherrif10 wants to merge 1 commit into
sherrif10 wants to merge 1 commit into
Conversation
Contributor
|
@sherrif10 Include the link of the ticket,also your commit message doesn't have a ticket ID.you can have a look at this https://wiki.openmrs.org/display/docs/Pull+Request+Tips |
Member
|
@sherrif10 did you see the above comments? |
Member
Author
|
@dkayiwa@openmrs.org <dkayiwa@openmrs.org> yes brother i will go a head
and update the commit
…On Mon, Aug 5, 2019 at 5:48 AM dkayiwa ***@***.***> wrote:
@sherrif10 <https://github.com/sherrif10> did you see the above comments?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#42?email_source=notifications&email_token=ALOKS6DRJBQRT42M3RFZAL3QDAOSNA5CNFSM4IEEGJS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3RWUEQ#issuecomment-518220306>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALOKS6GVTKO3Z55GGXHWMMDQDAOSNANCNFSM4IEEGJSQ>
.
|
Member
|
@sherrif10 are you still working on this? |
Member
Author
|
Let me bump into it but it seems it is not based on any ticket discription |
Member
|
@sherrif10 are you still working on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the line of code that could return all drugTypes in cohorBuiderController.java class on line 210
sherrif10@b26c158
@mseaton , @dkayiwa , @kaweesi , kindly review this PR and giude me where possible thanks