Skip to content

fix(kyc): require approve pubkey to match address#814

Closed
x0tta6bl4-ai wants to merge 1 commit into
openmetaearth:mainfrom
x0tta6bl4-ai:fix/kyc-approve-pubkey-address-binding
Closed

fix(kyc): require approve pubkey to match address#814
x0tta6bl4-ai wants to merge 1 commit into
openmetaearth:mainfrom
x0tta6bl4-ai:fix/kyc-approve-pubkey-address-binding

Conversation

@x0tta6bl4-ai

Copy link
Copy Markdown

Summary

  • derive the account address from MsgApprove.Pubkey during KYC approval
  • reject Approve when the derived pubkey address does not match MsgApprove.Address
  • add a regression test that verifies no DID or DID info is written on mismatch

Bounty

Refs #266

Payout wallet: 0x6017613e80d7893EB2aD5c0585b3f1f88CD6e099

Tests

  • go test ./x/kyc/keeper -run 'TestKeeperTestSuite/TestApproveRejectsPubkeyAddressMismatch' -count=1 -v\n- go test ./x/kyc/keeper -run 'TestKeeperTestSuite/Test(Approve|Remove|Update)$' -count=1 -v\n- git diff --check\n\n## Note\ngo test ./x/kyc/keeper -count=1 -v still fails on existing query assertions in grpc_query_test.go: TestDIDs, TestKYCs, and TestProtocol. The new mismatch regression test passes.

@koelzen koelzen added run-ci Trigger CI run and removed run-ci Trigger CI run labels Jun 10, 2026
@GAVINNB

GAVINNB commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Thank you for your revised PR. However, some additional features are still missing. We will continue to optimize and improve them in the future.

@GAVINNB GAVINNB closed this Jun 24, 2026
@GAVINNB GAVINNB added the invalid This doesn't seem right label Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

invalid This doesn't seem right

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants