Skip to content

fix: reject kyc remove vc through did#811

Closed
x0tta6bl4-ai wants to merge 1 commit into
openmetaearth:mainfrom
x0tta6bl4-ai:fix/did-reject-kyc-remove-vc
Closed

fix: reject kyc remove vc through did#811
x0tta6bl4-ai wants to merge 1 commit into
openmetaearth:mainfrom
x0tta6bl4-ai:fix/did-reject-kyc-remove-vc

Conversation

@x0tta6bl4-ai

Copy link
Copy Markdown

Fixes #365.

Summary

  • reject generic DID RemoveVC requests for the reserved KYC service id
  • add a DID keeper regression test proving KYC credentials and filters remain intact when the generic DID route is used
  • add a dedicated DID error for reserved credential services

Tests

  • go test ./x/did/keeper -run TestMsgServerRemoveVCRejectsKycReservedSid -count=1 -v
  • go test ./x/did/keeper -count=1 -v
  • go test ./x/did/types -count=1
  • git diff --check
  • git diff --cached --check

Baseline notes reproduced on clean origin/main at 9ca8f8fb:

  • go test ./x/did -count=1 -v fails in existing TestInitExportGenesis with empty address string is not allowed
  • go test ./x/kyc/types -count=1 fails in existing TestGenesisState_Validate expectations

Bounty payout wallet: 0x6017613e80d7893EB2aD5c0585b3f1f88CD6e099.

@koelzen koelzen added run-ci Trigger CI run and removed run-ci Trigger CI run labels Jun 10, 2026
@GAVINNB GAVINNB added the invalid This doesn't seem right label Jun 24, 2026
@GAVINNB GAVINNB closed this Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

invalid This doesn't seem right

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG BOUNTY] [Medium] [DID/KYC/MEGroup] DID RemoveVC bypasses KYC Remove lifecycle cleanup

3 participants