fix(gravity): clamp batch timeout projection height#1284
Open
jamilahmadzai wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #945.
This clamps the local ME height used by
GetBatchTimeoutHeightwhen the storedLastObservedBlockHeight.BlockHeightis ahead of the current context height, which can happen after genesis import or migration. Instead of subtracting a larger imported local height from a fresh height-1 context and underflowinguint64, the projection now treats elapsed local time as zero until the chain catches up.The external observed height is preserved, and the normal timeout window is still added on top of that height.
Validation
go test ./x/gravity/keeper -run 'TestGravityKeeperTestSuite/TestBatchTimeoutHeightDoesNotUnderflowWhenObservedLocalHeightAhead' -count=1 -vgo test ./x/gravity/keeper -count=1go test ./x/gravity/... -count=1go test ./... -count=1git diff --checkPayout
Meta Earth bug bounty payout in
$MECvia ME Pass wallet:me1ya82w6cjflk9r2qeyfeu64sm7gxtfr7mu62w9j