fix(wstaking): block region moves with delegations#1234
Open
jamilahmadzai wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1230.
This blocks
UpdateValidatorregion reassignment when the old region still has active delegated funds. The current flow callsUnBondRegion(oldRegionId), which clears the old region operator before users in that region can safely undelegate, delegate again, or withdraw rewards. Rejecting the reassignment whileDelegateAmountis non-zero keeps the old region state intact and avoids locking those delegations behind an empty operator address.A reassignment with no delegated funds still follows the existing path and binds the validator to the new empty region.
Tests
go test ./x/wstaking/keeper -run 'TestKeeperTestSuite/TestUpdateValidator(RejectsRegionMoveWithDelegations|MovesRegionWithoutDelegations)$' -count=1 -vgo test ./x/wstaking/keeper -count=1go test ./x/wstaking/... -count=1git diff --checkBounty payout
Meta Earth bug bounty payout in
$MECvia ME Pass:me1ya82w6cjflk9r2qeyfeu64sm7gxtfr7mu62w9j