fix(wmint): avoid begin blocker mint panics#1048
Open
modelsbridgeaicom-ship-it wants to merge 1 commit into
Open
fix(wmint): avoid begin blocker mint panics#1048modelsbridgeaicom-ship-it wants to merge 1 commit into
modelsbridgeaicom-ship-it wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the WMINT-NEW-001 portion of #276.
BeginBlockerpreviously panicked if minting or treasury transfer failed. It also wrote minted counters before those bank operations completed. This change runs the minted counters,MintCoins, and treasury transfer in a cache context, logs and returns on failure, and commits only after both bank operations succeed. That prevents begin-block failures from halting the chain or leaving partial wmint state behind.Tests
Passed: