Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions x/wnft/types/msgs.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@ func (msg MsgNewClass) GetSignBytes() []byte {
return sdk.MustSortJSON(bz)
}
func (msg MsgNewClass) GetSigners() []sdk.AccAddress {
signer, _ := sdk.AccAddressFromBech32(msg.Sender)
return []sdk.AccAddress{signer}
return []sdk.AccAddress{sdk.MustAccAddressFromBech32(msg.Sender)}
}
func (msg MsgNewClass) ValidateBasic() error {
if len(msg.ClassId) == 0 {
Expand Down Expand Up @@ -102,8 +101,7 @@ func (m MsgMintNFT) ValidateBasic() error {

// GetSigners returns the expected signers for MsgMintNFT.
func (m MsgMintNFT) GetSigners() []sdk.AccAddress {
signer, _ := sdk.AccAddressFromBech32(m.Creator)
return []sdk.AccAddress{signer}
return []sdk.AccAddress{sdk.MustAccAddressFromBech32(m.Creator)}
}

// Route implements the sdk.Msg interface.
Expand Down Expand Up @@ -153,8 +151,7 @@ func (m MsgSend) ValidateBasic() error {

// GetSigners returns the expected signers for MsgSend.
func (m MsgSend) GetSigners() []sdk.AccAddress {
signer, _ := sdk.AccAddressFromBech32(m.Sender)
return []sdk.AccAddress{signer}
return []sdk.AccAddress{sdk.MustAccAddressFromBech32(m.Sender)}
}

// GetSignBytes get the bytes for the message signer to sign on
Expand Down
21 changes: 21 additions & 0 deletions x/wnft/types/msgs_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
package types

import (
"testing"

"github.com/stretchr/testify/require"
)

func TestGetSignersPanicsOnInvalidAddresses(t *testing.T) {
require.Panics(t, func() {
MsgNewClass{Sender: "not-a-bech32-address"}.GetSigners()
})

require.Panics(t, func() {
MsgMintNFT{Creator: "not-a-bech32-address"}.GetSigners()
})

require.Panics(t, func() {
MsgSend{Sender: "not-a-bech32-address"}.GetSigners()
})
}
Loading