#14 Update clients.py to pass remote URL to DOAJ when it's available#15
Open
justingonder wants to merge 2 commits intoopenlibhums:masterfrom
Open
#14 Update clients.py to pass remote URL to DOAJ when it's available#15justingonder wants to merge 2 commits intoopenlibhums:masterfrom
justingonder wants to merge 2 commits intoopenlibhums:masterfrom
Conversation
In order to pass remote URLs to DOAJ when they are available, replaced reference to article.url with {% if article.is_remote and article.remote_url %}{{ article.remote_url }}{% else %}{{ article.url }}{% endif %} and since there seems to be no remote equivalent to article.pdf_url, replaced that reference with same.
ajrbyers
approved these changes
Nov 19, 2025
joemull
requested changes
Feb 18, 2026
Member
joemull
left a comment
joemull
left a comment
There was a problem hiding this comment.
Hi @justingonder, this won't work as intended since this is a Python file, and it won't recognize the curly-bracket syntax like {%. So it just needs to be rewritten in Python.
Member
|
I'll go ahead and add this to Triage so we can slot it into work to be done. |
Member
|
Im not sure how I missed that... |
Author
|
@joemull gave it a shot |
joemull
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to pass remote URLs to DOAJ when they are available, replaced reference to article.url with {% if article.is_remote and article.remote_url %}{{ article.remote_url }}{% else %}{{ article.url }}{% endif %} and since there seems to be no remote equivalent to article.pdf_url, replaced that reference with same.
Closes #14