fix: goroutine leak and dropped WithContext return value#167
fix: goroutine leak and dropped WithContext return value#167pabloszel11 wants to merge 2 commits intomainfrom
Conversation
pabloszel11
commented
May 4, 2026
- fix goroutine leak in Transaction -- Remove the unnecessary goroutine and channel in resource_repository.go:138-153. Call txFunc directly within GORM's Transaction callback. One-line fix that eliminates goroutine leak and use-after-rollback race under context cancellation.
- fix dropped WithContext return value -- Change dbCon.WithContext(ctx) to dbCon = dbCon.WithContext(ctx) in postgres.go:25 so context propagation actually applies to the DB handle.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |