feat: add CLI commands for fetching parent and descendant keys#153
Merged
Conversation
jithinkunjachan
force-pushed
the
feat/fetch-key-4
branch
from
5c6e452 to
6f58f57
Compare
Signed-off-by: jK <33685667+jithinkunjachan@users.noreply.github.com>
jithinkunjachan
force-pushed
the
feat/fetch-key-4
branch
from
6f58f57 to
9f2e6ac
Compare
jithinkunjachan
commented
Jun 10, 2026
| totalLen := 0 | ||
| trees := resp.GetKeyTree() | ||
| for i := range trees { | ||
| totalLen += len(trees[i].GetKeys()) + 1 |
Contributor
Author
There was a problem hiding this comment.
NP
The empty separator row (keyTreeRow{}) is also included in --json output, resulting in objects with all empty fields. Should we only insert separators for tabular format and omit them from JSON?
{
Kind: "K1"
...
},
{Kind:""},
{
Kind: "K2"
...
},
{
Kind: "K2"
...
},
{Kind:""},
{
Kind.:"K3"
}We could also remove this empty {} if required for json output any suggestions.
Contributor
There was a problem hiding this comment.
I think it is fine for now. We could also revisit output.Format, convert it to an interface and only the tabular implementation has a field separateAfter []RowIndex which is taken into account when the rows will be rendered.
fabenan-f
approved these changes
Jun 10, 2026
Signed-off-by: jK <33685667+jithinkunjachan@users.noreply.github.com>
apatsap
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This covers the main intent of the changes:
parent-key out
decendant-key out