Skip to content

feat/add static secret cryptor#151

Merged
jithinkunjachan merged 5 commits into
mainfrom
feat/add-static-secret-cryptor
Jun 9, 2026
Merged

feat/add static secret cryptor#151
jithinkunjachan merged 5 commits into
mainfrom
feat/add-static-secret-cryptor

Conversation

@jithinkunjachan

@jithinkunjachan jithinkunjachan commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@jithinkunjachan jithinkunjachan self-assigned this Jun 4, 2026
@jithinkunjachan jithinkunjachan force-pushed the feat/add-static-secret-cryptor branch 2 times, most recently from e9fd80b to c48f798 Compare June 4, 2026 11:13
@jithinkunjachan jithinkunjachan marked this pull request as ready for review June 4, 2026 11:14
Comment thread internal/cryptor/staticsecret.go Outdated
Comment thread internal/cryptor/staticsecret.go Outdated
@jithinkunjachan jithinkunjachan changed the title Feat/add static secret cryptor feat/add static secret cryptor Jun 4, 2026
Comment thread internal/cryptor/staticsecret.go Outdated
Comment thread internal/cryptor/staticsecret.go Outdated
Comment thread internal/cryptor/staticsecret.go Outdated
Comment thread internal/cryptor/staticsecret.go Outdated
Comment thread internal/cryptor/staticsecret.go Outdated
Signed-off-by: jK <33685667+jithinkunjachan@users.noreply.github.com>
Signed-off-by: jK <33685667+jithinkunjachan@users.noreply.github.com>
…and introduce CryptorSecret type

Signed-off-by: jK <33685667+jithinkunjachan@users.noreply.github.com>
@jithinkunjachan jithinkunjachan force-pushed the feat/add-static-secret-cryptor branch from a17d8f9 to ea4f363 Compare June 5, 2026 07:32

@apatsap apatsap left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some refactoring suggestions

Comment thread internal/cryptor/aes256gcm/aes256gcm.go Outdated
Comment thread internal/cryptor/staticsecret/staticsecret.go Outdated
Comment thread internal/cryptor/cryptor.go Outdated
Comment thread internal/cryptor/cryptor.go Outdated
Comment thread internal/cryptor/cryptor.go Outdated
@jithinkunjachan jithinkunjachan requested a review from apatsap June 5, 2026 08:39
…ctors

Signed-off-by: jK <33685667+jithinkunjachan@users.noreply.github.com>

@apatsap apatsap left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!!

Signed-off-by: jK <33685667+jithinkunjachan@users.noreply.github.com>

@fabenan-f fabenan-f left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job!

@jithinkunjachan jithinkunjachan merged commit 5f2012b into main Jun 9, 2026
5 checks passed
@jithinkunjachan jithinkunjachan deleted the feat/add-static-secret-cryptor branch June 9, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants