feat: add AES-256 secret key generation with secure memory#149
Merged
Conversation
Signed-off-by: jK <33685667+jithinkunjachan@users.noreply.github.com>
Signed-off-by: jK <33685667+jithinkunjachan@users.noreply.github.com>
Signed-off-by: jK <33685667+jithinkunjachan@users.noreply.github.com>
jithinkunjachan
force-pushed
the
feat/add-secret-gen
branch
from
fee97a5 to
4395963
Compare
apatsap
approved these changes
Jun 3, 2026
apatsap
left a comment
apatsap
left a comment
There was a problem hiding this comment.
Just one small NP. Its your call if you want to change it
Comment on lines
+48
to
+51
| _, err = rand.Read(b) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to generate random bytes: %w", err) | ||
| } |
There was a problem hiding this comment.
Technically rand.Read never returns an error. The signature is chosen like this only to satisfy io.Reader
https://pkg.go.dev/crypto/rand#Read
So we could make it shorter and add a comment about the no-error behaviour
Signed-off-by: jK <33685667+jithinkunjachan@users.noreply.github.com>
fabenan-f
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add simple secret generator