-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add base key api and announce key req #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
NamanBalaji
wants to merge
2
commits into
main
Choose a base branch
from
feat/key-model-and-announce-key-req
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| syntax = "proto3"; | ||
|
|
||
|
|
||
| package krypton.v1.keys; | ||
|
|
||
| option go_package = "github.com/openkcm/krypton/pkg/api/v1/proto/keys"; | ||
|
|
||
| service Service { | ||
| rpc AnnounceKey(AnnounceKeyRequest) returns (AnnounceKeyResponse); | ||
| rpc GetKey(GetKeyRequest) returns (GetKeyResponse); | ||
| } | ||
|
|
||
| message Key { | ||
| string id = 1; | ||
| string name = 2; | ||
| string tenant_id = 3; | ||
| string kind = 4; | ||
| string parent_id = 5; | ||
| string managed_by = 6; | ||
| map<string, string> labels = 7; | ||
| string state = 8; | ||
| int64 created_at = 9; | ||
| int64 updated_at = 10; | ||
| } | ||
|
|
||
| message AnnounceKeyRequest { | ||
| string tenant_id = 1; | ||
| string kind = 2; | ||
| string name = 3; | ||
| string parent_id = 4; | ||
| string target_name = 5; | ||
| map<string, string> labels = 6; | ||
| } | ||
|
|
||
| message AnnounceKeyResponse { | ||
| Key key = 1; | ||
| } | ||
|
|
||
| message GetKeyRequest { | ||
| string id = 1; | ||
| string tenant_id = 2; | ||
| } | ||
|
|
||
| message GetKeyResponse { | ||
| Key key = 1; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| package reconciler | ||
|
|
||
| import ( | ||
| "context" | ||
|
|
||
| "github.com/openkcm/orbital" | ||
|
|
||
| "github.com/openkcm/krypton/internal/config" | ||
| ) | ||
|
|
||
| const DefaultMaxPendingReconciles = defaultMaxPendingReconciles | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ✅ |
||
| const NoJobHandlerRegisteredMessage = noJobHandlerRegisteredMessage | ||
|
|
||
| var BuildTargets = buildTargets | ||
| var JobHandlerNotFoundError = jobHandlerNotFoundError | ||
|
|
||
| func (m *Manager) OrbitalManager() *orbital.Manager { | ||
| return m.orbitalManager | ||
| } | ||
|
|
||
| func (m *Manager) ConfirmJob(ctx context.Context, job orbital.Job) (orbital.JobConfirmerResult, error) { | ||
| return m.confirmJob(ctx, job) | ||
| } | ||
|
|
||
| func (m *Manager) ResolveTasks(ctx context.Context, job orbital.Job, cursor orbital.TaskResolverCursor) (orbital.TaskResolverResult, error) { | ||
| return m.resolveTasks(ctx, job, cursor) | ||
| } | ||
|
|
||
| func (m *Manager) JobDone(ctx context.Context, job orbital.Job) error { | ||
| return m.jobDone(ctx, job) | ||
| } | ||
|
|
||
| func (m *Manager) JobFailed(ctx context.Context, job orbital.Job) error { | ||
| return m.jobFailed(ctx, job) | ||
| } | ||
|
|
||
| func (m *Manager) JobCanceled(ctx context.Context, job orbital.Job) error { | ||
| return m.jobCanceled(ctx, job) | ||
| } | ||
|
|
||
| var NewTargetProvider = func(fn func(context.Context, config.ReconcilerTarget) (orbital.Initiator, error)) TargetProvider { | ||
| return TargetProvider(fn) | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering if we don't want to keep the packages organized by consumer type meaning moving the
KeyServiceto thekrypton.v1.adminpackage. This would also mean we need to prefix the existingServicewithTenant. This would group admin-related operations together and make the API more intuitive for consumers