feat: add base key api and announce key req#132
Conversation
NamanBalaji
force-pushed
the
feat/key-model-and-announce-key-req
branch
from
bbdce53 to
728d7dd
Compare
| syntax = "proto3"; | ||
|
|
||
|
|
||
| package krypton.v1.keys; |
There was a problem hiding this comment.
I was wondering if we don't want to keep the packages organized by consumer type meaning moving the KeyService to the krypton.v1.admin package. This would also mean we need to prefix the existing Service with Tenant. This would group admin-related operations together and make the API more intuitive for consumers
| // Code generated by protoc-gen-go-grpc. DO NOT EDIT. | ||
| // versions: | ||
| // - protoc-gen-go-grpc v1.6.1 | ||
| // - protoc-gen-go-grpc v1.5.1 |
There was a problem hiding this comment.
We should use the latest version if possible
| "github.com/openkcm/krypton/internal/clock" | ||
| ) | ||
|
|
||
| type KeyState string |
There was a problem hiding this comment.
I think the intention was to have a processing state like this state and a key (lifecycle) state which is already defined by the keylifecycle.State, so I'd rename this to be more precise
| return nil, err | ||
| } | ||
|
|
||
| key.Kind = kind |
There was a problem hiding this comment.
Do we require this shall we put it directly inside the row.Scan ?
| key.Kind = kind |
| "github.com/openkcm/krypton/internal/config" | ||
| ) | ||
|
|
||
| const DefaultMaxPendingReconciles = defaultMaxPendingReconciles |
| var parentID *string | ||
| if req.GetParentId() != "" { | ||
| p := req.GetParentId() | ||
| parentID = &p |
There was a problem hiding this comment.
A new feature
| parentID = &p | |
| parentID = new(req.GetParentId()) |
3 participants
No description provided.