added reconciler pacakge with manager creation logic#131
Merged
Conversation
push-tags-from-workflow
Bot
added
dependencies
NamanBalaji
requested review from
apatsap,
fabenan-f and
jithinkunjachan
and removed request for
apatsap and
jithinkunjachan
apatsap
requested changes
May 6, 2026
Comment on lines
+29
to
+38
| // TargetClientFactory builds Orbital initiators from reconciler targets. | ||
| type TargetClientFactory interface { | ||
| NewInitiator(ctx context.Context, target config.ReconcilerTarget) (orbital.Initiator, error) | ||
| } | ||
|
|
||
| type TargetClientFactoryFunc func(context.Context, config.ReconcilerTarget) (orbital.Initiator, error) | ||
|
|
||
| func (f TargetClientFactoryFunc) NewInitiator(ctx context.Context, target config.ReconcilerTarget) (orbital.Initiator, error) { | ||
| return f(ctx, target) | ||
| } |
There was a problem hiding this comment.
We have TargetClientFactory and TargetClientFactoryFunc.
Can't we make it more simplistic and just use:
type TargetProvider func(context.Context, config.ReconcilerTarget) (orbital.Initiator, error)
Because technically TargetClientFactoryFunc is exactly that just wrapped in another interface.
Contributor
Author
There was a problem hiding this comment.
Yes makes sense we just have targets of one type so it's overcomplicating
NamanBalaji
force-pushed
the
feat/integrate-orbital
branch
from
425da03 to
2a1a728
Compare
apatsap
approved these changes
May 6, 2026
jithinkunjachan
approved these changes
May 7, 2026
| if err != nil { | ||
| return nil, errors.Join(fmt.Errorf("create target %s client: %w", targetConfig.Name, err), closeTargets(ctx, targets)) | ||
| } | ||
| if client == nil { |
Contributor
There was a problem hiding this comment.
Just a small thing will we return a nil without an error?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.