Skip to content

Task/workflow approver changes#269

Open
doanhluongsap wants to merge 3 commits intomainfrom
task/workflow-approver-changes
Open

Task/workflow approver changes#269
doanhluongsap wants to merge 3 commits intomainfrom
task/workflow-approver-changes

Conversation

@doanhluongsap
Copy link
Copy Markdown
Contributor

@doanhluongsap doanhluongsap commented Apr 24, 2026

Summary by CodeRabbit

  • New Features
    • Workflows now include informational metadata about approver eligibility status.
    • System validates approvers remain eligible before processing their votes.
    • Displays warnings when insufficient eligible approvers are available.
    • Enhanced error reporting for eligibility check failures.

@doanhluongsap doanhluongsap self-assigned this Apr 24, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 24, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4f56d47f-8ff6-4a98-b7d3-e953368c7bae

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

This pull request extends workflow metadata to include eligibility-related informational messages. The OpenAPI specification and corresponding Go types now define WorkflowAdditionalInfo (containing code, severity, and message fields) as optional metadata on workflows. The transformation layer, manager, and controller logic are updated to compute eligibility conditions (insufficient eligible approvers and approver eligibility check failures), populate the additional info field accordingly, and expose errors with appropriate HTTP status codes. The manager's GetWorkflowByID method now returns an additional boolean and performs eligibility filtering based on IAM/SCIM group membership.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@doanhluongsap doanhluongsap force-pushed the task/workflow-approver-changes branch 3 times, most recently from 86ea132 to c65b20f Compare April 27, 2026 09:54
@doanhluongsap
Copy link
Copy Markdown
Contributor Author

@coderabbitai summary

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 27, 2026

✅ Actions performed

Summary regeneration triggered.

@doanhluongsap
Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 27, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@doanhluongsap doanhluongsap marked this pull request as ready for review April 27, 2026 11:03
@doanhluongsap doanhluongsap marked this pull request as draft April 27, 2026 15:32
@doanhluongsap doanhluongsap force-pushed the task/workflow-approver-changes branch 3 times, most recently from 3860ae6 to 8883916 Compare April 27, 2026 17:46
@doanhluongsap doanhluongsap marked this pull request as ready for review April 27, 2026 17:47
niazkhansap
niazkhansap previously approved these changes Apr 28, 2026
@doanhluongsap doanhluongsap force-pushed the task/workflow-approver-changes branch from e44e61a to ddc6fd1 Compare April 28, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants