Skip to content

feat: put system state as under workflow on workflow creation#259

Open
jmpTeixeira02 wants to merge 3 commits intomainfrom
task/system-under-workflow-data
Open

feat: put system state as under workflow on workflow creation#259
jmpTeixeira02 wants to merge 3 commits intomainfrom
task/system-under-workflow-data

Conversation

@jmpTeixeira02
Copy link
Copy Markdown
Contributor

@jmpTeixeira02 jmpTeixeira02 commented Apr 22, 2026

Summary by CodeRabbit

Release Notes

  • New Features
    • Systems now support an "Under Workflow" status to track approval progress.
    • System responses include integrated workflow details and approval information when a system is under review.
    • Workflow visibility is role-aware: approvers and initiators see full details; other users see limited information.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 22, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e6028a0a-88bc-46b9-9795-083cc8529ca1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

The changes consolidate workflow representation by removing the separate DetailedWorkflow type from the OpenAPI schema and generated API models. The base Workflow model is extended with optional fields (approverGroups, decisions, availableTransitions, approvalSummary) previously exclusive to detailed responses. A new UNDER\\_WORKFLOW system status is introduced, and SystemMetadata gains an optional workflow property. Transformation logic is refactored to use functional options for enriching workflow data. The system controller is updated to conditionally populate workflow details based on user role, and the workflow manager now updates system status to UNDER\\_WORKFLOW when workflows are created.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

niazkhansap
niazkhansap previously approved these changes Apr 22, 2026
@jmpTeixeira02 jmpTeixeira02 force-pushed the task/system-under-workflow-data branch from cf4acc1 to 9f32daf Compare April 22, 2026 15:25
@nnicora
Copy link
Copy Markdown
Contributor

nnicora commented Apr 23, 2026

@coderabbitai summary

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 23, 2026

✅ Actions performed

Summary regeneration triggered.

Comment thread internal/controllers/cmk/system_controller.go Outdated
@jmpTeixeira02 jmpTeixeira02 force-pushed the task/system-under-workflow-data branch 5 times, most recently from e79368b to 06f2a2a Compare April 24, 2026 11:44
@jmpTeixeira02 jmpTeixeira02 force-pushed the task/system-under-workflow-data branch from 06f2a2a to 794f9b4 Compare April 24, 2026 11:59
niazkhansap
niazkhansap previously approved these changes Apr 28, 2026
@jmpTeixeira02 jmpTeixeira02 force-pushed the task/system-under-workflow-data branch from 72b802e to 8c20dc0 Compare April 29, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants