Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
cb80
force-pushed
the
systemStatusLocked
branch
from
3f0ce28 to
f0cddba
Compare
| // STATUS_LOCKED means that the L1 key is unavailable and therefore the data | ||
| // of the system can't be decrypted. This is because the key chain to decrypt | ||
| // the data encryption key is incomplete. | ||
| // A system transition into STATUS_LOCKED happens when the tenant is terminated |
There was a problem hiding this comment.
A system transition into STATUS_LOCKED happens
Maybe we can make it sound more optional.
"Can happen". This is meant to handle the error case, when a System cannot be transferred to CSEK (customer-specific encryption key) due to unavailability of the L1 key.
efrank-at-sap
left a comment
efrank-at-sap
left a comment
There was a problem hiding this comment.
LGTM in general. We can maybe improve the doc string as mentioned above.
2 participants
No description provided.