docs: Add Code of Conduct link and EU funding logo to README#89
docs: Add Code of Conduct link and EU funding logo to README#89jithinkunjachan merged 1 commit intomainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
There was a problem hiding this comment.
Pull request overview
Updates repository documentation to highlight community guidelines and acknowledge EU funding in the project’s README.
Changes:
- Adds a second “Code of Conduct” section/link at the end of the README.
- Adds an EU funding logo image to the README.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ## Code of Conduct | ||
|
|
||
| To facilitate a nice environment for all, check out our [Code of Conduct](https://github.com/openkcm/.github/blob/main/CODE_OF_CONDUCT.md). |
There was a problem hiding this comment.
The PR description says it adds a Code of Conduct link, but the README already includes a Code of Conduct section/link earlier in the file. Please either update the description to reflect the actual change (e.g., repositioning/duplicating) or adjust the README change so it truly adds the missing content without duplication.
|
|
||
| ## Code of Conduct | ||
|
|
||
| To facilitate a nice environment for all, check out our [Code of Conduct](https://github.com/openkcm/.github/blob/main/CODE_OF_CONDUCT.md). | ||
|
|
There was a problem hiding this comment.
README now contains two separate "## Code of Conduct" sections (one above "Licensing" and this newly added one). Please keep a single Code of Conduct section to avoid duplication and confusion.
| ## Code of Conduct | |
| To facilitate a nice environment for all, check out our [Code of Conduct](https://github.com/openkcm/.github/blob/main/CODE_OF_CONDUCT.md). |
|
|
||
| Copyright 2025 SAP SE or an SAP affiliate company and OpenKCM contributors. Please see our [LICENSE](LICENSE) for copyright and license information. Detailed information including third-party components and their licensing/copyright information is available [via the REUSE tool](https://api.reuse.software/info/github.com/openkcm/api-sdk). | ||
|
|
||
|
|
There was a problem hiding this comment.
There are two consecutive blank lines added before the new section, which introduces unnecessary whitespace in the README. Consider keeping a single blank line between sections for consistent formatting.
|
|
||
| To facilitate a nice environment for all, check out our [Code of Conduct](https://github.com/openkcm/.github/blob/main/CODE_OF_CONDUCT.md). | ||
|
|
||
| <p align="center"><img alt="Bundesministerium für Wirtschaft und Energie (BMWE)-EU funding logo" src="https://apeirora.eu/assets/img/BMWK-EU.png" width="400"/></p> |
There was a problem hiding this comment.
The EU funding logo is loaded from an external domain (apeirora.eu), which can create availability/privacy issues if the host changes or goes down. Consider vendoring the image into the repo (or using a GitHub-hosted asset) and note that the alt text acronym "BMWE" doesn’t match the image filename "BMWK-EU.png"—please verify the correct naming.
| <p align="center"><img alt="Bundesministerium für Wirtschaft und Energie (BMWE)-EU funding logo" src="https://apeirora.eu/assets/img/BMWK-EU.png" width="400"/></p> | |
| <p align="center"><img alt="Bundesministerium für Wirtschaft und Klimaschutz (BMWK) – EU funding logo" src="./BMWK-EU.png" width="400"/></p> |
2fed5b9 to
4937273
Compare
This PR adds a link to the Code of Conduct and the EU funding logo to the README.