Skip to content

feat: add optional client_id field to ApplyAuthRequest#87

Closed
pabloszel11 wants to merge 1 commit intomainfrom
feat/applyauth-optional-clientid
Closed

feat: add optional client_id field to ApplyAuthRequest#87
pabloszel11 wants to merge 1 commit intomainfrom
feat/applyauth-optional-clientid

Conversation

@pabloszel11
Copy link
Copy Markdown
Contributor

@pabloszel11 pabloszel11 commented Mar 18, 2026

Summary by CodeRabbit

  • New Features
    • Added optional client identifier support to authentication requests.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 18, 2026

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMar 18, 2026, 12:12 PM

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 18, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 05cee521-1a95-46ce-8fa9-3b52ee2948ef

📥 Commits

Reviewing files that changed from the base of the PR and between f86303e and 8faff84.

⛔ Files ignored due to path filters (1)
  • proto/kms/api/cmk/registry/auth/v1/auth.pb.go is excluded by !**/*.pb.go
📒 Files selected for processing (2)
  • proto/kms/api/cmk/registry/auth/v1/auth.pb.validate.go
  • proto/kms/api/cmk/registry/auth/v1/auth.proto

📝 Walkthrough

Walkthrough

Two related changes add a new optional client_id field to the ApplyAuthRequest protobuf message. The field definition is added to the .proto file, and corresponding no-op validation code is auto-generated in the validation file.

Changes

Cohort / File(s) Summary
Protobuf Auth Message Definition
proto/kms/api/cmk/registry/auth/v1/auth.proto
Added optional client_id field (string, field number 5) to ApplyAuthRequest message.
Protobuf Validation Code
proto/kms/api/cmk/registry/auth/v1/auth.pb.validate.go
Auto-generated no-op validation block for the new ClientId field in ApplyAuthRequest.validate method.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A client identifier hops into view,
Field number five, so fresh and new,
The proto declares it, validation agrees,
With no rules to check, just gentle ease!
thump thump 🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is entirely missing. The author did not provide any description following the repository's template structure. Add a pull request description following the template format, including sections for 'What this PR does / why we need it', 'Special notes for your reviewer', and 'Release note'.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding an optional client_id field to ApplyAuthRequest, matching the actual modifications in both the .proto and .pb.validate.go files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/applyauth-optional-clientid
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can suggest fixes for GitHub Check annotations.

Configure the reviews.tools.github-checks setting to adjust the time to wait for GitHub Checks to complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants