Skip to content

feat: rpc error details#79

Merged
alienvspredator merged 1 commit intomainfrom
feature/error-details
Mar 11, 2026
Merged

feat: rpc error details#79
alienvspredator merged 1 commit intomainfrom
feature/error-details

Conversation

@alienvspredator
Copy link
Copy Markdown
Member

Define some RPC error details returned by the API

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 4, 2026

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMar 4, 2026, 4:50 PM

Comment thread proto/kms/api/cmk/rpc/v1/error_details.proto
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't we just import google.golang.org/genproto/googleapis/rpc/errdetails? That's the same code.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't want to pull unnecessary dependencies, and googleapis are huge and a lots of them are related to google services specifically

@alienvspredator alienvspredator merged commit 9679065 into main Mar 11, 2026
9 checks passed
@alienvspredator alienvspredator deleted the feature/error-details branch March 11, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants