Skip to content

feat: updated SystemIdentifier to have type instead of region #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gogro merged 3 commits into from
Dec 18, 2025
Merged

feat: updated SystemIdentifier to have type instead of region #70

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0fabe40
feat: updated SystemIdntifier to have type instead of region and rela…
NamanBalaji Dec 8, 2025
99e26c7
introducing deprecated fields to maintain backwards compatablity
NamanBalaji Dec 16, 2025
d216efd
separated mapping RPCs from system service and removed SystemIdentifi…
gogro Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions proto/kms/api/cmk/registry/auth/v1/auth_grpc.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

194 changes: 97 additions & 97 deletions proto/kms/api/cmk/registry/system/v1/system.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

147 changes: 141 additions & 6 deletions proto/kms/api/cmk/registry/system/v1/system.pb.validate.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions proto/kms/api/cmk/registry/system/v1/system.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
}

message DeleteSystemRequest {
string external_id = 1;
SystemIdentifier system_identifier = 1;

Check failure on line 68 in proto/kms/api/cmk/registry/system/v1/system.proto

View workflow job for this annotation

GitHub Actions / buf 

Field "1" on message "DeleteSystemRequest" changed name from "external_id" to "system_identifier".

Check failure on line 68 in proto/kms/api/cmk/registry/system/v1/system.proto

View workflow job for this annotation

GitHub Actions / buf 

Field "1" with name "system_identifier" on message "DeleteSystemRequest" changed type from "string" to "message".

Check failure on line 68 in proto/kms/api/cmk/registry/system/v1/system.proto

View workflow job for this annotation

GitHub Actions / buf 

Field "1" with name "system_identifier" on message "DeleteSystemRequest" changed option "json_name" from "externalId" to "systemIdentifier".

Check failure on line 68 in proto/kms/api/cmk/registry/system/v1/system.proto

View workflow job for this annotation

GitHub Actions / buf 

Field "1" with name "system_identifier" on message "DeleteSystemRequest" changed cardinality from "optional with implicit presence" to "optional with explicit presence".
string region = 2;
}

Expand All @@ -74,7 +74,7 @@
}

message UpdateSystemL1KeyClaimRequest {
string external_id = 1;
SystemIdentifier system_identifier = 1;

Check failure on line 77 in proto/kms/api/cmk/registry/system/v1/system.proto

View workflow job for this annotation

GitHub Actions / buf 

Field "1" on message "UpdateSystemL1KeyClaimRequest" changed name from "external_id" to "system_identifier".

Check failure on line 77 in proto/kms/api/cmk/registry/system/v1/system.proto

View workflow job for this annotation

GitHub Actions / buf 

Field "1" with name "system_identifier" on message "UpdateSystemL1KeyClaimRequest" changed type from "string" to "message".

Check failure on line 77 in proto/kms/api/cmk/registry/system/v1/system.proto

View workflow job for this annotation

GitHub Actions / buf 

Field "1" with name "system_identifier" on message "UpdateSystemL1KeyClaimRequest" changed option "json_name" from "externalId" to "systemIdentifier".

Check failure on line 77 in proto/kms/api/cmk/registry/system/v1/system.proto

View workflow job for this annotation

GitHub Actions / buf 

Field "1" with name "system_identifier" on message "UpdateSystemL1KeyClaimRequest" changed cardinality from "optional with implicit presence" to "optional with explicit presence".
Copy link
Copy Markdown
Contributor

@gogro gogro Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont reuse indices please

Copy link
Copy Markdown
Contributor Author

@NamanBalaji NamanBalaji Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need backwards compatibility for this ?

string region = 2;
string tenant_id = 3;
bool l1key_claim = 4;
Expand Down Expand Up @@ -102,7 +102,7 @@
}

message UpdateSystemStatusRequest {
string external_id = 1;
SystemIdentifier system_identifier = 1;

Check failure on line 105 in proto/kms/api/cmk/registry/system/v1/system.proto

View workflow job for this annotation

GitHub Actions / buf 

Field "1" with name "system_identifier" on message "UpdateSystemStatusRequest" changed option "json_name" from "externalId" to "systemIdentifier".

Check failure on line 105 in proto/kms/api/cmk/registry/system/v1/system.proto

View workflow job for this annotation

GitHub Actions / buf 

Field "1" with name "system_identifier" on message "UpdateSystemStatusRequest" changed cardinality from "optional with implicit presence" to "optional with explicit presence".
string region = 2;
kms.api.cmk.types.v1.Status status = 3;
}
Expand All @@ -113,11 +113,11 @@

message SystemIdentifier {
string external_id = 1;
string region = 2;
string type = 2;
}

message SetSystemLabelsRequest {
string external_id = 1;
SystemIdentifier system_identifier = 1;
string region = 2;
Copy link
Copy Markdown
Contributor

@gogro gogro Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should region move to SystemIdentifier?

Copy link
Copy Markdown
Contributor Author

@NamanBalaji NamanBalaji Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idea is to have a clear sepration between "logical" and regional systems. SystemIdentifier currently serves the purpose of identifying the logical system so I don't think adding region to it makes sense.

map<string, string> labels = 3;
}
Expand All @@ -127,7 +127,7 @@
}

message RemoveSystemLabelsRequest {
string external_id = 1;
SystemIdentifier system_identifier = 1;
string region = 2;
repeated string label_keys = 3; // Keys of labels to delete
}
Expand Down
22 changes: 11 additions & 11 deletions proto/kms/api/cmk/registry/system/v1/system_grpc.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 11 additions & 11 deletions proto/kms/api/cmk/registry/tenant/v1/tenant_grpc.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading