Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8329227: Seek might hang with fMP4 H.265/HEVC or H.265/HEVC over HTTP/FILE #1775

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sashamatveev
Copy link
Member

@sashamatveev sashamatveev commented Apr 12, 2025

  • Fixed by reloading decoder for each seek.
  • Tested with all H.265 files for HLS/HTTP/FILE, no issues found.
  • Seek performance is not affected or at least I did not notice any performance issues when doing reload for each seek.

This is workaround and no other reasonable solutions were found.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8329227: Seek might hang with fMP4 H.265/HEVC or H.265/HEVC over HTTP/FILE (Bug - P2)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1775/head:pull/1775
$ git checkout pull/1775

Update a local copy of the PR:
$ git checkout pull/1775
$ git pull https://git.openjdk.org/jfx.git pull/1775/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1775

View PR using the GUI difftool:
$ git pr show -t 1775

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1775.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 12, 2025

👋 Welcome back almatvee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 12, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Ready for review label Apr 12, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 12, 2025

Webrevs

@kevinrushforth
Copy link
Member

Reviewers: @kevinrushforth @arapte

/reviewers 2

@openjdk
Copy link

openjdk bot commented Apr 12, 2025

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Ready for review
Development

Successfully merging this pull request may close these issues.

2 participants