8350813: Rendering of bulky sound bank from MIDI sequence can cause OutOfMemoryError #702
+61
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is backport of "JDK-8350813 Rendering of bulky sound bank from MIDI sequence can cause OutOfMemoryError"
The problem exists in jdk8 also.
Almost clean backport, resolved conflict in copyright, and put
BulkSoundBank.java
tojdk/test/javax/sound/midi/BulkSoundBank/
.Test fails before the fix, and passes with the fix.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/702/head:pull/702
$ git checkout pull/702
Update a local copy of the PR:
$ git checkout pull/702
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/702/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 702
View PR using the GUI difftool:
$ git pr show -t 702
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/702.diff
Using Webrev
Link to Webrev Comment