Skip to content

Conversation

wkia
Copy link

@wkia wkia commented Sep 23, 2025

This is backport of "JDK-8350813 Rendering of bulky sound bank from MIDI sequence can cause OutOfMemoryError"

The problem exists in jdk8 also.

Almost clean backport, resolved conflict in copyright, and put BulkSoundBank.java to jdk/test/javax/sound/midi/BulkSoundBank/.

Test fails before the fix, and passes with the fix.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8350813 needs maintainer approval

Issue

  • JDK-8350813: Rendering of bulky sound bank from MIDI sequence can cause OutOfMemoryError (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/702/head:pull/702
$ git checkout pull/702

Update a local copy of the PR:
$ git checkout pull/702
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/702/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 702

View PR using the GUI difftool:
$ git pr show -t 702

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/702.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 23, 2025

👋 Welcome back rmarchenko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 23, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport fcc2a24291d499f7149debad1250903ddc369d91 8350813: Rendering of bulky sound bank from MIDI sequence can cause OutOfMemoryError Sep 23, 2025
@openjdk
Copy link

openjdk bot commented Sep 23, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Sep 23, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 23, 2025

Webrevs

@wkia
Copy link
Author

wkia commented Sep 24, 2025

The failed CertPathValidator tests don't look related to the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant