Skip to content

Conversation

johnshajiang
Copy link
Member

@johnshajiang johnshajiang commented Sep 18, 2025

java/util/zip/DeflateIn_InflateOut.java failed with a system zlib.
The backport is clean.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8240226 needs maintainer approval

Issue

  • JDK-8240226: DeflateIn_InflateOut.java test incorrectly assumes size of compressed file (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/698/head:pull/698
$ git checkout pull/698

Update a local copy of the PR:
$ git checkout pull/698
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/698/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 698

View PR using the GUI difftool:
$ git pr show -t 698

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/698.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 18, 2025

👋 Welcome back jjiang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 18, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 69f4ac1e0d61804b1bf306ee728a4de4397aeb47 8240226: DeflateIn_InflateOut.java test incorrectly assumes size of compressed file Sep 18, 2025
@openjdk
Copy link

openjdk bot commented Sep 18, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Sep 18, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 18, 2025

Webrevs

@johnshajiang
Copy link
Member Author

/approval request Backport JDK-8240226: DeflateIn_InflateOut.java test incorrectly assumes size of compressed file

@openjdk
Copy link

openjdk bot commented Sep 18, 2025

@johnshajiang
8240226: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Sep 18, 2025
@johnshajiang
Copy link
Member Author

This backport is test-only and should not caused those failures.
They look known issues, e.g. JDK-8303159 and JDK-8367256.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant