Skip to content

Conversation

jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Sep 9, 2025

Another problem list to get GHA green (at last).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8367257 needs maintainer approval

Issue

  • JDK-8367257: [8u] Problem list CAInterop.java#entrustrootcag4 test (Sub-task - P4 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/696/head:pull/696
$ git checkout pull/696

Update a local copy of the PR:
$ git checkout pull/696
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/696/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 696

View PR using the GUI difftool:
$ git pr show -t 696

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/696.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 9, 2025

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into pr/695 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 9, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@jerboaa
Copy link
Contributor Author

jerboaa commented Sep 9, 2025

GHA is green. Ready for review.

@jerboaa jerboaa marked this pull request as ready for review September 9, 2025 15:26
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 9, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 9, 2025

Webrevs

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/695 to master September 17, 2025 16:20
@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout jdk-8367257-problemlist-entrustrootcag4
git fetch https://git.openjdk.org/jdk8u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Nice you're keeping them in alphabetical order :)

@openjdk
Copy link

openjdk bot commented Sep 17, 2025

⚠️ @jerboaa This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@jerboaa
Copy link
Contributor Author

jerboaa commented Sep 18, 2025

/approval request Please approve this problem listing of a known-to-fail jdk_security_infra test. Risk is low as it's only affecting test runs.

@openjdk
Copy link

openjdk bot commented Sep 18, 2025

@jerboaa
8367257: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Sep 18, 2025
@jerboaa
Copy link
Contributor Author

jerboaa commented Sep 18, 2025

Of course we see the intermittent digicert failures now. ssslrootevrsaca seems to be intermittent as well. Good times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval Requires approval; will be removed when approval is received rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants