-
Notifications
You must be signed in to change notification settings - Fork 172
8367257: [8u] Problem list CAInterop.java#entrustrootcag4 test #696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
8367257: [8u] Problem list CAInterop.java#entrustrootcag4 test #696
Conversation
👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
GHA is green. Ready for review. |
Webrevs
|
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout jdk-8367257-problemlist-entrustrootcag4
git fetch https://git.openjdk.org/jdk8u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine. Nice you're keeping them in alphabetical order :)
|
/approval request Please approve this problem listing of a known-to-fail jdk_security_infra test. Risk is low as it's only affecting test runs. |
Of course we see the intermittent digicert failures now. |
Another problem list to get GHA green (at last).
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/696/head:pull/696
$ git checkout pull/696
Update a local copy of the PR:
$ git checkout pull/696
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/696/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 696
View PR using the GUI difftool:
$ git pr show -t 696
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/696.diff
Using Webrev
Link to Webrev Comment