8305072: Win32ShellFolder2.compareTo is inconsistent

[mrserb]

Hi all,

This pull request contains a backport of commit 2fcb8168 from the openjdk/jdk repository.

The commit being backported was authored by Alexey Ivanov on 9 Apr 2024 and was reviewed by Phil Race and Sergey Bylokhov.

The patch is mostly clean, I had to delete @modules and --add-opens in the test see 2dcba6b

The fix verified by the test, no new issues were found by the :jdk_desktop tests

Thanks!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8305072 needs maintainer approval

Issue

• JDK-8305072: Win32ShellFolder2.compareTo is inconsistent (Bug - P4)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/522/head:pull/522
$ git checkout pull/522

Update a local copy of the PR:
$ git checkout pull/522
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/522/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 522

View PR using the GUI difftool:
$ git pr show -t 522

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/522.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[bridgekeeper]

@mrserb This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[mlbridge]

Webrevs

• 02: Full - Incremental (0decb232)
• 01: Full - Incremental (f76a2bc3)
• 00: Full (2dcba6b8)

[openjdk]

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[bridgekeeper]

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@mrserb This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[mrserb]

/open

[openjdk]

@mrserb This pull request is now open