Skip to content

Conversation

deepakdamodaran
Copy link

@deepakdamodaran deepakdamodaran commented Oct 2, 2025

25u backport of 31847149c1956b23c19a99309982660b4bbdd2d6
Almost clean except one extra import statement at line no 44.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8325766 needs maintainer approval

Issue

  • JDK-8325766: Extend CertificateBuilder to create trust and end entity certificates programmatically (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/263/head:pull/263
$ git checkout pull/263

Update a local copy of the PR:
$ git checkout pull/263
$ git pull https://git.openjdk.org/jdk25u.git pull/263/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 263

View PR using the GUI difftool:
$ git pr show -t 263

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/263.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 2, 2025

👋 Welcome back ddamodaran! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 2, 2025

@deepakdamodaran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325766: Extend CertificateBuilder to create trust and end entity certificates programmatically

Reviewed-by: coffeys

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 7c60413: 8368367: Test jdk/jfr/event/gc/detailed/TestGCHeapMemoryUsageEvent.java fails jdk.GCHeapMemoryUsage "expected 0 > 0"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@coffeys) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 8325766 8325766: Extend CertificateBuilder to create trust and end entity certificates programmatically Oct 2, 2025
@openjdk
Copy link

openjdk bot commented Oct 2, 2025

This backport pull request has now been updated with the original issue, but not the original commit. If you have the original commit hash, please update the pull request title with Backport <hash>.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Oct 2, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 2, 2025

Webrevs

@deepakdamodaran
Copy link
Author

/approval JDK-8325766 request. Need to fix to achieve parity, Test change only, No risk.

@openjdk
Copy link

openjdk bot commented Oct 2, 2025

@deepakdamodaran
JDK-8325766: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Oct 2, 2025
Copy link
Contributor

@coffeys coffeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Oct 6, 2025
@deepakdamodaran
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 6, 2025
@openjdk
Copy link

openjdk bot commented Oct 6, 2025

@deepakdamodaran
Your change (at version a86d489) is now ready to be sponsored by a Committer.

@coffeys
Copy link
Contributor

coffeys commented Oct 6, 2025

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 6, 2025

Going to push as commit 61a014e.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 7c60413: 8368367: Test jdk/jfr/event/gc/detailed/TestGCHeapMemoryUsageEvent.java fails jdk.GCHeapMemoryUsage "expected 0 > 0"

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 6, 2025
@openjdk openjdk bot closed this Oct 6, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 6, 2025
@openjdk
Copy link

openjdk bot commented Oct 6, 2025

@coffeys @deepakdamodaran Pushed as commit 61a014e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants