Skip to content

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Oct 1, 2025

Improves jpackage and test reliability, especially with older glibc-s that have dlerror issues under concurrent access.

Additional testing:

  • Linux x86_64 server fastdebug, observing the failure with GCC 7.3.1
  • Linux x86_64 server fastdebug, sun/management/jmxremote, 20x, no failures
  • Linux x86_64 server fastdebug, tools/jpackage, 5x, no failures
  • Linux x86_64 server fastdebug, jdk_all, no failures

Progress

  • Change must not contain extraneous whitespace
  • JDK-8345810 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8345810: Custom launchers must be linked with pthread to avoid dynamic linker issues (Bug - P3 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/257/head:pull/257
$ git checkout pull/257

Update a local copy of the PR:
$ git checkout pull/257
$ git pull https://git.openjdk.org/jdk25u.git pull/257/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 257

View PR using the GUI difftool:
$ git pr show -t 257

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/257.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 1, 2025

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 1, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 685da0323b27abda5ab0484f4c8abaaeeff882ea 8345810: Custom launchers must be linked with pthread to avoid dynamic linker issues Oct 1, 2025
@openjdk
Copy link

openjdk bot commented Oct 1, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Oct 1, 2025
@shipilev
Copy link
Member Author

shipilev commented Oct 1, 2025

/approval request Improves jpackage and test reliability, especially with older glibc-s that have dlerror issues under concurrent access. Applies cleanly. Tests are failing on older machine without the fix, pass with it. All jpackage and other JDK tests pass. The patch was in mainline for a month without new issues. Risk is low-medium: affects jpackage linkage (see linked customer reports), but in a simple manner.

@shipilev shipilev marked this pull request as ready for review October 1, 2025 21:30
@openjdk
Copy link

openjdk bot commented Oct 1, 2025

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 1, 2025
@openjdk
Copy link

openjdk bot commented Oct 1, 2025

@shipilev
8345810: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Oct 1, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 1, 2025

Webrevs

@msgilligan
Copy link

@shipilev pardon my newb question, but is this PR likely to be included in 25.0.1 or 25.0.2?

msgilligan referenced this pull request in sparrowwallet/sparrow Oct 4, 2025
@shipilev
Copy link
Member Author

shipilev commented Oct 6, 2025

@shipilev pardon my newb question, but is this PR likely to be included in 25.0.1 or 25.0.2?

Current merge window is open for 25.0.2 (January 2026). 25.0.1 is way past the freeze.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants