-
Notifications
You must be signed in to change notification settings - Fork 76
8345810: Custom launchers must be linked with pthread to avoid dynamic linker issues #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
/approval request Improves jpackage and test reliability, especially with older glibc-s that have dlerror issues under concurrent access. Applies cleanly. Tests are failing on older machine without the fix, pass with it. All jpackage and other JDK tests pass. The patch was in mainline for a month without new issues. Risk is low-medium: affects jpackage linkage (see linked customer reports), but in a simple manner. |
|
@shipilev pardon my newb question, but is this PR likely to be included in 25.0.1 or 25.0.2? |
Current merge window is open for 25.0.2 (January 2026). 25.0.1 is way past the freeze. |
Improves jpackage and test reliability, especially with older glibc-s that have
dlerror
issues under concurrent access.Additional testing:
sun/management/jmxremote
, 20x, no failurestools/jpackage
, 5x, no failuresjdk_all
, no failuresProgress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/257/head:pull/257
$ git checkout pull/257
Update a local copy of the PR:
$ git checkout pull/257
$ git pull https://git.openjdk.org/jdk25u.git pull/257/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 257
View PR using the GUI difftool:
$ git pr show -t 257
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/257.diff
Using Webrev
Link to Webrev Comment