Skip to content

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Sep 30, 2025

Hi all,

This pull request contains a backport of JDK-8364454, commit ad0fd13f from the openjdk/jdk repository.

The commit being backported was authored by Ioi Lam on 12 Aug 2025 and was reviewed by Calvin Cheung.

It excludes a test for which a fix is in the makings in head.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8364454 needs maintainer approval

Issue

  • JDK-8364454: ProblemList runtime/cds/DeterministicDump.java on macos for JDK-8363986 (Sub-task - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/253/head:pull/253
$ git checkout pull/253

Update a local copy of the PR:
$ git checkout pull/253
$ git pull https://git.openjdk.org/jdk25u.git pull/253/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 253

View PR using the GUI difftool:
$ git pr show -t 253

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/253.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 30, 2025

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 30, 2025

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8364454: ProblemList runtime/cds/DeterministicDump.java on macos for JDK-8363986

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport ad0fd13f2007c93d8a109626a627823f30e4c8d7 8364454: ProblemList runtime/cds/DeterministicDump.java on macos for JDK-8363986 Sep 30, 2025
@openjdk
Copy link

openjdk bot commented Sep 30, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required approval Requires approval; will be removed when approval is received rfr Pull request is ready for review labels Sep 30, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 30, 2025

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Oct 6, 2025
@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 7, 2025

Going to push as commit a98b243.
Since your change was applied there have been 17 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 7, 2025
@openjdk openjdk bot closed this Oct 7, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 7, 2025
@openjdk
Copy link

openjdk bot commented Oct 7, 2025

@RealCLanger Pushed as commit a98b243.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the backport-RealCLanger-ad0fd13f-master branch October 7, 2025 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant