8358723: jpackage signing issues: the main launcher doesn't have entitlements

[alexeysemenyukoracle]

A clean backport of openjdk/jdk#27493 PR. It required backports of a couple of additional patches. Two minor conflicts required resolution. Both straightforward.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8358723 needs maintainer approval
• JDK-8334238 needs maintainer approval
• JDK-8364984 needs maintainer approval
• JDK-8368890 needs maintainer approval

Warning

 ⚠️ Found leading lowercase letter in issue title for 8358723: jpackage signing issues: the main launcher doesn't have entitlements

Issues

• JDK-8358723: jpackage signing issues: the main launcher doesn't have entitlements (Bug - P3 - Approved)
• JDK-8334238: Enhance AddLShortcutTest jpackage test (Enhancement - P3 - Approved)
• JDK-8364984: Many jpackage tests are failing on Linux after JDK-8334238 (Bug - P3 - Approved)
• JDK-8368890: open/test/jdk/tools/jpackage/macosx/NameWithSpaceTest.java fails randomly (Bug - P3 - Approved)

Reviewers

• Alexey Ivanov (@aivanov-jdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/250/head:pull/250
$ git checkout pull/250

Update a local copy of the PR:
$ git checkout pull/250
$ git pull https://git.openjdk.org/jdk25u.git pull/250/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 250

View PR using the GUI difftool:
$ git pr show -t 250

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/250.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358723: jpackage signing issues: the main launcher doesn't have entitlements
8334238: Enhance AddLShortcutTest jpackage test
8364984: Many jpackage tests are failing on Linux after JDK-8334238
8368890: open/test/jdk/tools/jpackage/macosx/NameWithSpaceTest.java fails randomly

Reviewed-by: aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

• 9df689f: 8361950: Update to use jtreg 8
• 6569f3e: 8361423: Add IPSupport::printPlatformSupport to java/net/NetworkInterface/IPv4Only.java
• a95aa60: 8359477: com/sun/net/httpserver/Test12.java appears to have a temp file race
• ... and 23 more: https://git.openjdk.org/jdk25u/compare/3747153d91e8f412fec9b3db4e42691eafc4f290...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aivanov-jdk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[alexeysemenyukoracle]

/issue add JDK-8334238 JDK-8364984

[openjdk]

@alexeysemenyukoracle
Adding additional issue to issue list: 8334238: Enhance AddLShortcutTest jpackage test.

Adding additional issue to issue list: 8364984: Many jpackage tests are failing on Linux after JDK-8334238.

[alexeysemenyukoracle]

/issue add JDK-8368890

[openjdk]

@alexeysemenyukoracle
Adding additional issue to issue list: 8368890: open/test/jdk/tools/jpackage/macosx/NameWithSpaceTest.java fails randomly.

[mlbridge]

Webrevs

• 01: Full - Incremental (ab5b3c65)
• 00: Full (2c3d2c47)

[alexeysemenyukoracle]

@aivanov-jdk PTAL

[aivanov-jdk]

Looks good.

[openjdk]

⚠️ @alexeysemenyukoracle This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[alexeysemenyukoracle]

/approval request

[openjdk]

@alexeysemenyukoracle
8358723: The approval request has been created successfully.
8334238: The approval request has been created successfully.
8364984: The approval request has been created successfully.
8368890: The approval request has been created successfully.

[alexeysemenyukoracle]

/integrate

[openjdk]

@alexeysemenyukoracle
Your change (at version ab5b3c6) is now ready to be sponsored by a Committer.

[shipilev]

/sponsor

[openjdk]

Going to push as commit 1bb4af8.
Since your change was applied there have been 27 commits pushed to the master branch:

• 8317086: 8366365: [test] test/lib-test/jdk/test/whitebox/CPUInfoTest.java should be updated
• 9df689f: 8361950: Update to use jtreg 8
• 6569f3e: 8361423: Add IPSupport::printPlatformSupport to java/net/NetworkInterface/IPv4Only.java
• ... and 24 more: https://git.openjdk.org/jdk25u/compare/3747153d91e8f412fec9b3db4e42691eafc4f290...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @alexeysemenyukoracle Pushed as commit 1bb4af8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.