-
Notifications
You must be signed in to change notification settings - Fork 76
8368152: Shenandoah: Incorrect behavior at end of degenerated cycle #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
8368152: Shenandoah: Incorrect behavior at end of degenerated cycle #241
Conversation
Reviewed-by: kdnilsen, ysr
👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolution in degen_event_message() looks ok.
|
/approval request This change fixes an error that causes the generational mode for Shenandoah to run back-to-back degenerated and full GCs without raising an out-of-memory error as expected. More importantly, it fixes an error that causes other Shenandoah modes to run a full gc unconditionally after every degenerated cycle (making a bad situation worse). We have tested this fix on jtreg tiers 1-3 and on various benchmarks: dacapo, specjvm, specjbb, extremem, and renaissance. |
@earthling-amzn |
Not clean, but conflict was trivial to resolve.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/241/head:pull/241
$ git checkout pull/241
Update a local copy of the PR:
$ git checkout pull/241
$ git pull https://git.openjdk.org/jdk25u.git pull/241/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 241
View PR using the GUI difftool:
$ git pr show -t 241
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/241.diff
Using Webrev
Link to Webrev Comment