Skip to content

Conversation

earthling-amzn
Copy link

@earthling-amzn earthling-amzn commented Sep 24, 2025

Not clean, but conflict was trivial to resolve.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8368152 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8368152: Shenandoah: Incorrect behavior at end of degenerated cycle (Bug - P4 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/241/head:pull/241
$ git checkout pull/241

Update a local copy of the PR:
$ git checkout pull/241
$ git pull https://git.openjdk.org/jdk25u.git pull/241/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 241

View PR using the GUI difftool:
$ git pr show -t 241

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/241.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 24, 2025

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 24, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport f36c33c86df0400d2155bfadd9a6b5ea56743133 8368152: Shenandoah: Incorrect behavior at end of degenerated cycle Sep 24, 2025
@openjdk
Copy link

openjdk bot commented Sep 24, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Sep 24, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 24, 2025

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolution in degen_event_message() looks ok.

@openjdk
Copy link

openjdk bot commented Sep 29, 2025

⚠️ @earthling-amzn This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@earthling-amzn
Copy link
Author

/approval request This change fixes an error that causes the generational mode for Shenandoah to run back-to-back degenerated and full GCs without raising an out-of-memory error as expected. More importantly, it fixes an error that causes other Shenandoah modes to run a full gc unconditionally after every degenerated cycle (making a bad situation worse). We have tested this fix on jtreg tiers 1-3 and on various benchmarks: dacapo, specjvm, specjbb, extremem, and renaissance.

@openjdk
Copy link

openjdk bot commented Oct 1, 2025

@earthling-amzn
8368152: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants