8292043: Incorrect decoding near EOF for stateful decoders like UTF-16 #4177
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting JDK-8292043: Incorrect decoding near EOF for stateful decoders like UTF-16. Fixes incorrect state handling with EOF in StreamDecoder. There's a reset() call to the decoder seeing the EOF before the last decode() operation to handle the state correctly. Removing the call should not affect other cases because reset() is issued down the execution.
Also adds a new test. Ran GHA Sanity Checks (passed) and new test (passed). Patch is clean.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4177/head:pull/4177$ git checkout pull/4177Update a local copy of the PR:
$ git checkout pull/4177$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4177/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4177View PR using the GUI difftool:
$ git pr show -t 4177Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4177.diff
Using Webrev
Link to Webrev Comment