Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8346049: jdk/test/lib/security/timestamp/TsaServer.java warnings #3447

Closed

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Apr 6, 2025

I backport this for parity with 17.0.16-oracle.

verified with
test/jdk/sun/security/tools/jarsigner/TsacertOptionTest.java
test/jdk/sun/security/tools/jarsigner/TimestampCheck.java
which use this class.


Progress

  • Change must not contain extraneous whitespace
  • JDK-8346049 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8346049: jdk/test/lib/security/timestamp/TsaServer.java warnings (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3447/head:pull/3447
$ git checkout pull/3447

Update a local copy of the PR:
$ git checkout pull/3447
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3447/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3447

View PR using the GUI difftool:
$ git pr show -t 3447

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3447.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 6, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 6, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346049: jdk/test/lib/security/timestamp/TsaServer.java warnings

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 1eb54e4228ba9319ac2f980055ed366dd861ec0b 8346049: jdk/test/lib/security/timestamp/TsaServer.java warnings Apr 6, 2025
@openjdk
Copy link

openjdk bot commented Apr 6, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 6, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 6, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 6, 2025

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Apr 7, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Apr 7, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Apr 7, 2025

Going to push as commit b8887da.
Since your change was applied there have been 16 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 7, 2025
@openjdk openjdk bot closed this Apr 7, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 7, 2025
@openjdk
Copy link

openjdk bot commented Apr 7, 2025

@GoeLin Pushed as commit b8887da.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant