8271419: Refactor test code for modifying CDS archive contents

[GoeLin]

I backport this to make later test backports easier.
Resolved as later "8271707: migrate tests to use jdk.test.whitebox.WhiteBox" was already backported.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8271419 needs maintainer approval

Issue

• JDK-8271419: Refactor test code for modifying CDS archive contents (Enhancement - P4 - Approved)

Reviewers

• Matthias Baesken (@MBaesken - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3445/head:pull/3445
$ git checkout pull/3445

Update a local copy of the PR:
$ git checkout pull/3445
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3445/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3445

View PR using the GUI difftool:
$ git pr show -t 3445

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3445.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271419: Refactor test code for modifying CDS archive contents

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• 4d51cd8: 8258483: [TESTBUG] gtest CollectorPolicy.young_scaled_initial_ergo_vm fails if heap is too small
• 36e703a: 8321931: memory_swap_current_in_bytes reports 0 as "unlimited"
• 95e6cbd: 8315871: Opensource five more Swing regression tests
• 729b0c7: 8352649: [17u] guarantee(is_result_safe || is_in_asgct()) failed inside AsyncGetCallTrace

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (a0aefb59)

[MBaesken]

8271419 has a CSR link
JDK-8320926 Refactor test code for modifying CDS archive contents

Any idea why ? Is this still of importance ?

[GoeLin]

Hi,
the CSR was created wrongly. I think it has no meaning. It has no text, only the default. Also, a CSR makes no sense for a test only change.

[openjdk]

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[GoeLin]

/integrate

[openjdk]

Going to push as commit 7a29de5.
Since your change was applied there have been 20 commits pushed to the master branch:

• b6b498c: 8345133: Test sun/security/tools/jarsigner/TsacertOptionTest.java failed: Warning found in stdout
• 7cfd95c: 8281511: java/net/ipv6tests/UdpTest.java fails with checkTime failed
• b8887da: 8346049: jdk/test/lib/security/timestamp/TsaServer.java warnings
• 495aa75: 8345357: test/jdk/javax/swing/JRadioButton/8033699/bug8033699.java fails in ubuntu22.04
• d24239b: 8340978: Open source few DnD tests - Set6
• 0648c86: 8341378: Open source few TrayIcon tests - Set8
• 37dc379: 8340967: Open source few Cursor tests - Set2
• 628e182: 8340555: Open source DnD tests - Set4
• 26ff4f5: 8340625: Open source additional Component tests (part 3)
• da0dd46: 8341239: Open source closed frame tests # 3
• ... and 10 more: https://git.openjdk.org/jdk17u-dev/compare/bb103d7d0914f90e85eb5f87831ffef1de536072...master

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin Pushed as commit 7a29de5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.